Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 🦄 Shades of Purple Theme + Scripts + Docs #8

Merged
merged 4 commits into from
Aug 29, 2018

Conversation

ahmadawais
Copy link
Contributor

With this PR I intend to add my VSCode theme 🦄 Shades of Purple to prism-react-render.

  • 🦄 NEW: Shades of Purple Theme for Prism

I converted the theme and manually edited it to make sure it looks good. Here's demo of how it looks:
image

  • 🐛 FIX: Prettier devDependency required to Commit with Husky

Since there is no contribution guide I had to figure things out on the go and found out that Husky need prettier which was not installed/required as a devDependency in the project. Assumption of having it installed globally is a bit much IMO. So, I added it in there.

  • 📖 DOC: Generate a Prism Theme from VSCode

I also wrote basic documentation for someone looking to generate a theme like I did. Thanks for working out the prism theme generator.

  • 👌 IMPROVE: Start npm script for theme generation

Added an npm script to easily run the theme generator.

Looking forward, peace! ✌️

Copy link
Contributor

@kitten kitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! These are some awesome docs contributions and I really like the addition of this theme ✨

@@ -111,6 +111,7 @@
"jest": "^23.5.0",
"lint-staged": "^7.2.2",
"npm-run-all": "^4.1.3",
"prettier": "^1.14.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this! It missing was simply an oversight 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's what I thought! 👌

@kitten kitten merged commit fc57458 into FormidableLabs:master Aug 29, 2018
@ahmadawais
Copy link
Contributor Author

@kitten glad you liked it. I hope you try out the VSCode theme as well. I hear it's pretty rad. 💜😎

Thanks for the merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants