This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Update Infra #969 - Replace isparta with istanbul #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blainekasten
force-pushed
the
infra/istanbul-coverage
branch
from
c54f469
to
248cd68
Compare
ryan-roemer
suggested changes
Dec 5, 2018
blainekasten
force-pushed
the
infra/istanbul-coverage
branch
4 times, most recently
from
ed531e7
to
9e5b52e
Compare
ryan-roemer
reviewed
Dec 5, 2018
ryan-roemer
reviewed
Dec 5, 2018
blainekasten
force-pushed
the
infra/istanbul-coverage
branch
2 times, most recently
from
08f5571
to
9e5b52e
Compare
ryan-roemer
approved these changes
Dec 5, 2018
There was a problem hiding this comment.
I've pushed my changes fixing a pre-existing issue wherein we always instrumented + ran coverage. Now we only do it when running the coverage commands 😛
@blainekasten -- can you review my commits to make sure they're good and pull them down and kick the tires?
@kylecesmat -- can you give both of us a review?
thanks!
blainekasten
force-pushed
the
infra/istanbul-coverage
branch
3 times, most recently
from
132232f
to
262d629
Compare
blainekasten
force-pushed
the
infra/istanbul-coverage
branch
from
262d629
to
81cb49d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #969
Changes from using
ispartatoistanbulfor test coverage.