Skip to content
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.

Fix initial enhancer state for fn components #1041

Conversation

nathanmarks
Copy link
Contributor

@nathanmarks nathanmarks commented Jan 22, 2020

This addresses #1034

The listener in the plugin where the error is being raised will run and if _radiumStyleState: {} hasn't been set by another action yet we have issues. There is a test enforcing this initial state for class components and I have added one for function components and fixed the issue.

cc @dancherb

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.711% when pulling eadf5df on nathanmarks:func-component-initial-enhancer-state into e1fa4f7 on FormidableLabs:master.

@nathanmarks
Copy link
Contributor Author

@boygirl just a friendly ping -- can you let me know if we'll be able to merge and release a patch version for this?

Copy link
Contributor

@kylecesmat kylecesmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do apologize for leaving this PR unmerged for quite a few months - Thank you so much for this fix! It will be released in a patch version

@kylecesmat kylecesmat merged commit 57d6a13 into FormidableLabs:master Sep 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants