This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 309
ESM build, misc other tweaks #968
Merged
Merged
Changes from 37 commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
0664f58
ignore es
826e402
rm babel-plugin-transform-es2015-modules-commonjs
ed52d6d
stashing changes
35157c4
setting a lib and es env in babel
fc9242d
whitelist es directory
4244c21
drop support for node 4
d0fe194
babel-env fix
7bf64ff
is this working yet
af66fc3
finish dropping support for node 4
222bd0c
dont lint my lib
406d560
WIP: Some updates.
ryan-roemer e8ca0f8
WIP: make webpack build better / parallel. Still getting error.
ryan-roemer 8574d15
Need babel env for commands
ryan-roemer 6685882
Convert examples to real ESM. Tests broken
ryan-roemer b51ff05
WIP: Broken add-module-exports works in karma, but doesn't produce ri…
ryan-roemer a18c881
WIP: Breaking node api fixes test.
ryan-roemer 3d0368f
Leave ESM import for server example
ryan-roemer ec9ec97
WIP: Attempt node4 again
ryan-roemer ec99b54
Remove package-lock.json
ryan-roemer b9f914d
WIP: babel plugin inserts after body. Need inline.
ryan-roemer 578f1c1
WIP: Last notes before nuking
ryan-roemer b0e031d
WIP: client tests broken. We are BREAKING the API....
ryan-roemer 2d95e39
Add changelog
ryan-roemer 93ae41f
update instances of `server`
b2826df
Add root index.
ryan-roemer 22f4802
WIP: skip failing tests to isolate work.
ryan-roemer cd8ed87
Fix tests.
ryan-roemer abd481d
Update changelog entry
ryan-roemer 6690c0e
last fix
0443622
Merge branch 'task/es-build-ryan' of https://github.com/FormidableLab…
2b30e22
Update all readme examples
ryan-roemer 781794e
Merge fix
ryan-roemer 6b8fe28
Various misc fixes
ryan-roemer 2c5aedf
Fix git install to correctly build.
ryan-roemer 1aa5743
Update changelog
ryan-roemer 9526ded
Upgrade webpack for umd default export. #969
ryan-roemer 32d50e4
Update babel-loader
ryan-roemer 75fc5bc
Final notes and tweaks
ryan-roemer 2467b74
Add readme message
ryan-roemer 69ef53d
Add webpack resolve.alias solution too.
ryan-roemer f05b617
typo
ryan-roemer ac9301b
More readme finess
ryan-roemer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,22 @@ | ||
{ | ||
"plugins": [ | ||
"add-module-exports", | ||
"transform-es2015-modules-commonjs", | ||
"transform-decorators-legacy" | ||
], | ||
"presets": [ | ||
["es2015", { "loose": true }], | ||
["env", { "modules": false }], | ||
"stage-1", | ||
"react" | ||
] | ||
], | ||
"env": { | ||
"commonjs": { | ||
"presets": [ | ||
"env", | ||
"stage-1", | ||
"react" | ||
], | ||
"plugins": [ | ||
"transform-decorators-legacy" | ||
] | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,2 +1,3 @@ | ||
dist | ||
lib | ||
es |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,7 +31,9 @@ $RECYCLE.BIN/ | |
_site | ||
coverage | ||
dist | ||
es | ||
lib | ||
node_modules | ||
npm-debug.log* | ||
yarn-error.log* | ||
package-lock.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
/* | ||
!/es | ||
!/dist | ||
!/docs | ||
!/lib | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,15 +1,14 @@ | ||
module.exports = { | ||
resetListStyle: { | ||
listStyle: 'none' | ||
}, | ||
resetBoxModel: { | ||
marginTop: 0, | ||
marginRight: 0, | ||
marginBottom: 0, | ||
marginLeft: 0, | ||
paddingTop: 0, | ||
paddingRight: 0, | ||
paddingBottom: 0, | ||
paddingLeft: 0 | ||
} | ||
export const resetListStyle = { | ||
listStyle: 'none' | ||
}; | ||
|
||
export const resetBoxModel = { | ||
marginTop: 0, | ||
marginRight: 0, | ||
marginBottom: 0, | ||
marginLeft: 0, | ||
paddingTop: 0, | ||
paddingRight: 0, | ||
paddingBottom: 0, | ||
paddingLeft: 0 | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
module.exports = require('./lib').default; | ||
module.exports.default = module.exports; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not need
.default
on this import?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct. That is the change with the new root
index.js
file.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. 👍