Feature/fast deep equal@2.0.1 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 4, 2018 13:31
* null and object comparison * new behavior: different functions that are not equal * new behavior: handle NaN
* Move tests from fast-deep-equal@2.0.1 to separate file * Add comments to identify fast-deep-equal code * Add comments to identify custom handling for React
|
Easier diff (w/o whitespace changes): https://github.com/FormidableLabs/react-fast-compare/pull/21/files?w=1 |
chrisbolin
reviewed
Jun 4, 2018
| @@ -0,0 +1,389 @@ | |||
| // this is from fast-deep-equal spec/test.js | |||
There was a problem hiding this comment.
for context, I had Samuel move all of the fast-deep-equal tests to a separate file so it was easier to keep up-to-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get up to date with fast-deep-equal@2.0.1
Fixes Update to track fast-deep-equal@2.0.1 #15