Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename exportedEqual to isEqual #59

Merged
merged 1 commit into from Feb 5, 2020
Merged

rename exportedEqual to isEqual #59

merged 1 commit into from Feb 5, 2020

Conversation

chrisbolin
Copy link
Contributor

In JS this function name is irrelevant, but in TypeScript this name is visible in many editors (e.g. PhpStorm, see #58).

Copy link
Member

@ryan-roemer ryan-roemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chrisbolin chrisbolin merged commit 1210a90 into master Feb 5, 2020
chrisbolin added a commit that referenced this pull request Feb 6, 2020
@kale-stew kale-stew deleted the export-name branch May 5, 2020 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants