Add Preact support #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Mimic existing React tests for Preact, update deps * Test cleanup / PR feedback * Tie React-specific checks together * Testing yarn lock changes * Focus on supporting preact/compat, revert index chng * Drop support for node@8 * Fix node coverage * Transpile preact for ie tests * Bump CI versions * Fix win ci * Switch to codecov Co-authored-by: Ryan Roemer <ryan.roemer@formidable.com>
ryan-roemer
approved these changes
May 8, 2020
There was a problem hiding this comment.
Everything looks great!!!
CodeCov is picking up correctly, so now we have a coverage badge too.
Once last thing I'd like to see is an update of our badge size (and READM bullet point if above 650b but I don't think so) per https://github.com/FormidableLabs/react-fast-compare/blob/master/CONTRIBUTING.md#before-submitting-a-pr as we've likely added a few bytes to yarn size-min-gz
|
Oh, haha, you even got the byte size bundle image too. Rock on! 🤜 🤛 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR consolidates the Preact support introduced in #67 and tests for that work introduced in #75 for a single minor release.
Checklist:
639)