Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace deprecated UNSAFE_componentWillMount in LiveProvider #220

Closed
christianvuerings opened this issue Sep 21, 2020 · 0 comments
Closed

Replace deprecated UNSAFE_componentWillMount in LiveProvider #220

christianvuerings opened this issue Sep 21, 2020 · 0 comments
Assignees
@bkonkle

Comments

@christianvuerings
Copy link

Repro steps

Result

https://fb.me/react-unsafe-component-lifecycles

1.chunk.js:91945 Warning: Using UNSAFE_componentWillMount in strict mode is not recommended and may indicate bugs in your code. See https://fb.me/react-unsafe-component-lifecycles for details.

  • Move code with side effects to componentDidMount, and set initial state in the constructor.
    Please update the following components: LiveProvider

image

Expected result

No warnings

Code reference

LiveProvider.js#L27: https://git.io/JUubn
@bkonkle bkonkle self-assigned this Oct 1, 2020
jpdriver added a commit that referenced this issue Jun 27, 2021
@jpdriver
Merge pull request #226 from FormidableLabs/issue/220-no-component-wi…
edba11c 
…ll-mount

Move LiveProvider to hooks, fixes #220
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bkonkle bkonkle

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bkonkle @christianvuerings