Update package.json #183
Open
Update package.json #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@kitten @sofiapoh Is there a reason we were using an exact version of `buble`? I'd like to be able to pick up this commit bublejs/buble@3a1e5d1 from the latest release. Prior to this commit, `buble` (and therefore `react-live`) was being published with an untranspiled dependency (`regexpu-core`)
|
There was a release of buble after that pinned version that added massive dependencies or broke something else, I'll take a look at the situation with it now but it's been a difficult dependency and we should look at alternatives potentially |
|
@sofiapoh I don't know what you use buble for, but MDX uses a forked version, buble-jsx-only, since this PR Edit: don't use buble-jsx-only at this time; seems to not tree-shake well, causing the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kitten @sofiapoh Is there a reason for using an exact version of
buble?I'd like to be able to pick up this commit bublejs/buble@3a1e5d1 from the latest release. Prior to this commit,
buble(and thereforereact-live) was being published with an untranspiled dependency (regexpu-core). I found this out while working on the renature docs.react-staticthrows an error about es6 syntax in the bundled app.