Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json #183

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update package.json #183

wants to merge 2 commits into from

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Jan 30, 2020

@kitten @sofiapoh Is there a reason for using an exact version of buble?

I'd like to be able to pick up this commit bublejs/buble@3a1e5d1 from the latest release. Prior to this commit, buble (and therefore react-live) was being published with an untranspiled dependency (regexpu-core). I found this out while working on the renature docs. react-static throws an error about es6 syntax in the bundled app.

@kitten @sofiapoh Is there a reason we were using an exact version of `buble`? 

I'd like to be able to pick up this commit bublejs/buble@3a1e5d1 from the latest release. Prior to this commit, `buble` (and therefore `react-live`) was being published with an untranspiled dependency (`regexpu-core`)
@sofiapoh
Copy link
Contributor

There was a release of buble after that pinned version that added massive dependencies or broke something else, I'll take a look at the situation with it now but it's been a difficult dependency and we should look at alternatives potentially

@tomByrer
Copy link

tomByrer commented Feb 21, 2020

@sofiapoh I don't know what you use buble for, but MDX uses a forked version, buble-jsx-only, since this PR

Edit: don't use buble-jsx-only at this time; seems to not tree-shake well, causing the /dist folder grow 10x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants