This repository has been archived by the owner on Dec 15, 2018. It is now read-only.
Add navigation confirmation/blocking API #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tptee
commented
Jan 30, 2018
| @@ -150,6 +149,19 @@ goBack(); | |||
|
|
|||
| // Equivalent to the browser forward button | |||
| goForward(); | |||
|
|
|||
| // Creates a function that blocks navigation with window.confirm when returning a string. | |||
There was a problem hiding this comment.
This is the only real update to the readme–the rest is just Prettier
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=========================================
- Coverage 99.43% 98.6% -0.83%
=========================================
Files 28 28
Lines 354 359 +5
=========================================
+ Hits 352 354 +2
- Misses 2 5 +3
Continue to review full report at Codecov.
|
|
There's not a great way to test the |
ryan-roemer
approved these changes
Jan 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes
history's navigation confirmation/blocking API.