Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Change default basename from '/' to empty string #27

Merged
merged 1 commit into from
Aug 11, 2016

Conversation

brentschroeter
Copy link
Contributor

Setting basename to '/' prevents routes with a leading '/' from matching. For example, <Fragment forRoute="/test" /> will throw an exception when the user navigates to hostname/test.

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage remained the same at 98.374% when pulling 7cb40b7 on brentschroeter:fixes-default-basename into e9ad808 on FormidableLabs:master.

@tptee
Copy link
Contributor

tptee commented Aug 11, 2016

Looks great! Can you remove the dist/ build before I merge this? We only commit dist on release.

@brentschroeter
Copy link
Contributor Author

Sure thing!

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage remained the same at 98.374% when pulling c6ef1fc on brentschroeter:fixes-default-basename into e9ad808 on FormidableLabs:master.

@divmain
Copy link
Contributor

divmain commented Aug 11, 2016

@brentschroeter, still seeing dist files in the diff :)

@tptee
Copy link
Contributor

tptee commented Aug 11, 2016

Hey @brentschroeter , would you mind rebasing and only including the src/ change?

@brentschroeter
Copy link
Contributor Author

Apologies, fixing it as we speak.

@coveralls
Copy link

coveralls commented Aug 11, 2016

Coverage Status

Coverage remained the same at 98.374% when pulling f7e0883 on brentschroeter:fixes-default-basename into e9ad808 on FormidableLabs:master.

@brentschroeter
Copy link
Contributor Author

Done. I'm still very much on the git learning curve, so tips are always appreciated :)

@tptee
Copy link
Contributor

tptee commented Aug 11, 2016

No worries, that looks good! Thanks for the contribution! 😄

@tptee tptee merged commit 184dfeb into FormidableLabs:master Aug 11, 2016
@tptee
Copy link
Contributor

tptee commented Aug 11, 2016

Released as 7.0.1 🎉

@brentschroeter
Copy link
Contributor Author

Thanks for the router! Take care :)

@tptee
Copy link
Contributor

tptee commented Aug 11, 2016

You too! Let me know if you run into more problems!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants