This repository has been archived by the owner on Dec 15, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 113
Change default basename from '/' to empty string #27
Merged
tptee
merged 1 commit into
FormidableLabs:master
from
brentschroeter:fixes-default-basename
Aug 11, 2016
Merged
Change default basename from '/' to empty string #27
tptee
merged 1 commit into
FormidableLabs:master
from
brentschroeter:fixes-default-basename
Aug 11, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks great! Can you remove the |
Sure thing! |
@brentschroeter, still seeing |
Hey @brentschroeter , would you mind rebasing and only including the |
Apologies, fixing it as we speak. |
c6ef1fc
to
f7e0883
Compare
Done. I'm still very much on the git learning curve, so tips are always appreciated :) |
No worries, that looks good! Thanks for the contribution! 😄 |
Released as |
Thanks for the router! Take care :) |
You too! Let me know if you run into more problems! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting basename to '/' prevents routes with a leading '/' from matching. For example,
<Fragment forRoute="/test" />
will throw an exception when the user navigates tohostname/test
.