Skip to content
This repository has been archived by the owner on Dec 15, 2018. It is now read-only.

Fix noop on changed query, same path #89

Closed
wants to merge 2 commits into from

Conversation

mike-marcacci
Copy link

@mike-marcacci mike-marcacci commented Sep 21, 2016

Right now, if a query parameter is changed but the pathname remains the same, the reducer does not persist the state.

I would add tests, but I'm having trouble installing the dev deps (some OpenSSL error, may be due to the recent MacOS Sierra update).

EDIT:

To verify:

  1. go to a route
  2. click a <Link /> to the same page with a different query parameter

@mike-marcacci mike-marcacci changed the title Fix noop on changed query, same path fix noop on changed query, same path Sep 21, 2016
@mike-marcacci mike-marcacci changed the title fix noop on changed query, same path Fix noop on changed query, same path Sep 21, 2016
@mike-marcacci mike-marcacci changed the title Fix noop on changed query, same path Fixes #90 - noop on changed query, same path Sep 21, 2016
@mike-marcacci mike-marcacci changed the title Fixes #90 - noop on changed query, same path Fix noop on changed query, same path Sep 21, 2016
@tptee
Copy link
Contributor

tptee commented Sep 22, 2016

Thanks for finding this! I've got a PR out that simplifies the store enhancer, but it shuffles a bunch of stuff around. Can you see if this bug is still applicable there? #73

@mike-marcacci
Copy link
Author

Hi @tptee - I checked out that PR (which is an awesome change), but the problem persists. I will close this and make a new PR into the feature/new-store-enhancer-api branch with a fix.

@tptee
Copy link
Contributor

tptee commented Sep 22, 2016

Awesome, thanks for this! Will get to it soon 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants