Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 'display' to base #273

Closed
ndelangen opened this issue Jan 19, 2017 · 1 comment
Closed

Move 'display' to base #273

ndelangen opened this issue Jan 19, 2017 · 1 comment
Labels
Feature Request Request for or introduction of new functionality

Comments

@ndelangen
Copy link
Contributor

I'd like to use S and have it display-block. Currently I add style={{display:'inline-block'}}.

The Image component has a prop to tweak it's cssdisplay-property.

Maybe S should receive the same ability?

Either through adding it specificly to S or by moving the display prop to Base.
I think the latter makes sense.

I haven't made any contributions to spectacle before, but am interested in adding/tweaking this. Would you be interested in a PR, and if so which solution would you prefer?

@kenwheeler kenwheeler added the Feature Request Request for or introduction of new functionality label Jan 25, 2017
@kenwheeler
Copy link
Contributor

I'm going to remove prop based styling in favor of style tag/styled-components/glamorous type styling, so Base is going away

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Request for or introduction of new functionality
Projects
None yet
Development

No branches or pull requests

2 participants