Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Sidebar links to tutorial aren't anchored correctly. #794

Closed
ryan-roemer opened this issue Jan 10, 2020 · 0 comments · Fixed by #797
Closed

Docs: Sidebar links to tutorial aren't anchored correctly. #794

ryan-roemer opened this issue Jan 10, 2020 · 0 comments · Fixed by #797
Labels
🐛 Bug Issues or PRs that report or fix a bug 📖 Documentation Documentation requests or updates

Comments

@ryan-roemer
Copy link
Member

(Not sure if we take up in master or rewrite)

Quick side-issue to note: on https://formidable-com-spectacle-staging-791.surge.sh/open-source/spectacle/docs/tutorial/ the links to the numbered sections aren't working quite right:

LINK IN NAVBAR: https://formidable-com-spectacle-staging-791.surge.sh/open-source/spectacle/docs/tutorial/#4.-add-images

ACTUAL ANCHOR: https://formidable-com-spectacle-staging-791.surge.sh/open-source/spectacle/docs/tutorial/#4-add-images
@ryan-roemer ryan-roemer added 🐛 Bug Issues or PRs that report or fix a bug 📖 Documentation Documentation requests or updates labels Jan 10, 2020
@ryan-roemer ryan-roemer mentioned this issue Jan 10, 2020
Merged
ryan-roemer added a commit that referenced this issue Jan 10, 2020
@ryan-roemer
Infra: Deploy to prod. Fix slug generation and numbers. (#797)
fb3e099 
- Deploy to production for real! Part of #793 
- Fix slug headers. Fixes #794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug Issues or PRs that report or fix a bug 📖 Documentation Documentation requests or updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Infra: Deploy to prod! (And minor fixes). FormidableLabs/spectacle
1 participant
@ryan-roemer