Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade loader-utils, ts-jest, & babel/core to fix security warnings #1321

Merged
merged 5 commits into from Mar 11, 2024

Conversation

Burnett2k
Copy link
Member

@Burnett2k Burnett2k commented Mar 11, 2024

Unfortunately, upgrading loader-utils previously didn't fully remediate all warnings. In order to get to a non-vulnerable version, we need to bump major versions.

I ran the app locally to ensure it still works, and verified there's not any breaking changes in the new major version that would affect us.

Link to dependabot warning for loader-utils
Link to dependabot warning(s) for json5. 173 & 172

image

loader-utils change log
https://github.com/webpack/loader-utils/blob/master/CHANGELOG.md#200-2020-03-17

Babel change log
https://github.com/babel/babel/blob/main/CHANGELOG.md#v7196-2022-10-20

fixes loader-utils & json5 vulnerability in version 1.4.2. Part of #1318

fixes json5 vulnerability
fixes loader-utils vulnerability
Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: a8ca4c6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
spectacle Patch
spectacle-mdx-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spectacle-docs-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 4:33pm

@Burnett2k Burnett2k changed the title upgrade loader-utils to fix security warnings upgrade loader-utils, ts-jest, & babel/core to fix security warnings Mar 11, 2024
moves to a more secure json5 package
@Burnett2k Burnett2k merged commit a06f1d1 into main Mar 11, 2024
4 checks passed
@Burnett2k Burnett2k deleted the issue/1318-loader-utils branch March 11, 2024 18:49
This was referenced Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants