[Babel] Improve the production build #154
Conversation
|
lgtm! 🚀 |
[babel] Improve the production build
|
Thanks so much! |
| @@ -10,7 +10,7 @@ | |||
| "build:dist": "NODE_ENV=production webpack --config webpack.config.production.js", | |||
| "lint": "eslint --ext .js,.jsx src", | |||
| "deploy": "npm run build:dist && surge -p .", | |||
| "start": "node server.js" | |||
| "start": "NODE_ENV=development node server.js" | |||
There was a problem hiding this comment.
Side Note -- this will break windows compatibility. The build:dist is probably OK for breaking, but might be nice to have this still work. Can we just leave no NODE_ENV and have that be defaulted to be development?
(or, use builder envs ;) )
There was a problem hiding this comment.
Oups, I have forgotten to remove this line from my commit. Fell free to fix it, sorry.
There was a problem hiding this comment.
Awesome catch @ryan-roemer , fixed here a32123c
Does it make sense to build a Spectacle builder archetype for core too? Or just for the boilerplate?
There was a problem hiding this comment.
@kenwheeler -- I think just add builder alone to get the extra's like builder envs and builder concurrent and not worry about an archetype since spectacle itself is kind of a "one-off".
The spectacle-boilerplate could definitely be replaced by an archetype like builder-spectacle now that builder-init has landed.
That's my gut intuition, but it may be the case we could add init/ templates and init.js to spectacle itself and just have it all together.
oliviertassinari
changed the title
Fix #153.
And add some plugins for improving the production build.
propTypes.