Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gif support #497

Merged
merged 6 commits into from Dec 10, 2018
Merged

gif support #497

merged 6 commits into from Dec 10, 2018

Conversation

tinybeachthor
Copy link
Contributor

No description provided.

@manjula-dube
Copy link

manjula-dube commented May 12, 2018

Shouldn't we add svg support as well fir future?

example:

{ test: /\.(jpe?g|png|gif|svg)$/i, loader: "file-loader?name=/public/icons/[name].[ext]" }

@tinybeachthor
Copy link
Contributor Author

@manjula91 svg files are already handled by their own rule

{
    test: /\.(png|jpg|gif)$/,
    loader: 'url-loader?limit=8192',
},
{
    test: /\.svg$/,
    loader: 'url-loader?limit=10000&mimetype=image/svg+xml',
},

@rainboxx
Copy link
Contributor

Travis should pass once #527 is merged and this branch rebased.

@rainboxx
Copy link
Contributor

@WhoMeNope #527 is merged, could you rebase this so the checks are going through again? Thanks!

@kale-stew kale-stew merged commit 3b91801 into FormidableLabs:master Dec 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants