Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove specialized zoom handling and margins for slide content #611

Merged
merged 4 commits into from
Dec 3, 2018

Conversation

ebrillhart
Copy link
Contributor

@ebrillhart ebrillhart commented Nov 6, 2018

This removes custom zoom handling and reverts to using default browser zoom for more predictable behavior and better accessibility. Can discuss later if this change causes lots of issues for people.

Also uses a standard single margin for slide content instead of calculating based on margin/zoom level, as that was creating weird zoom issues and often doubling the amount of padding/margin.

fixes #607 and fixes #524

@justsml
Copy link

justsml commented Dec 1, 2018

Tested, looks great! Thanks @ebrillhart

@ebrillhart ebrillhart merged commit 5440d28 into master Dec 3, 2018
@ebrillhart ebrillhart deleted the task/remove-duplicate-margin branch December 3, 2018 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zoom-in doesn't scale slides & contents linearly <Slide margin={n}> gets double-applied
2 participants