(graphcache) - Increase consistency of __typename in cached results #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `__typename` field does not need to be added to root types by default and must not be added first, as it shouldn't be necessary. Instead we can assume that it's in the result and copy it over once it's reached in the selection iteration.
🦋 Changeset detectedLatest commit: a085142 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
force-pushed
the
fix/instructed-typename-ordering
branch
from
efdb1c1
to
f154c94
Compare
kitten
force-pushed
the
fix/instructed-typename-ordering
branch
from
f4c5b9d
to
3d55f8c
Compare
I believe this should be a minor bump since we're adding a new warning.
JoviDeCroock
approved these changes
Dec 2, 2020
Merged
This was referenced Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1184
Summary
Note: More testing is needed before we can safely ship this.
Increase the consistency of when and how the
__typenamefield is added to results. Instead of adding it by default and automatically first, the__typenamefield will now be added along with the usual selection set. Thewriteoperation will issue a warning if it's in the selection but missing in the result, as it should, and thequeryoperation will add it as it did before but at the correct position of the result, assuming that it's in all selection sets. The slight change here is that it now won't be added to root results by default and only if it's being queried explicitly.Set of changes
makeSelectionIteratorto iterate__typenamefielddata.__typenameassignment inreadSelectionand add special logic for__typenamefield assignmentquery.test.tscases to include__typenameexplicitly where needed