-
-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(graphcache) - Replace buildClientSchema with lean implementation #1189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 936721e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
force-pushed
the
refactor/build-client-schema
branch
from
December 3, 2020 06:20
cde88eb
to
b481ba7
Compare
kitten
force-pushed
the
refactor/build-client-schema
branch
from
December 3, 2020 06:25
b481ba7
to
ee0163b
Compare
kitten
force-pushed
the
refactor/build-client-schema
branch
from
December 3, 2020 07:32
43b1b6c
to
a7e183a
Compare
kitten
changed the title
RFC: (graphcache) - Replace GraphQLSchema with custom implementation
(graphcache) - Replace buildClientSchema with lean implementation
Dec 3, 2020
JoviDeCroock
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, wooooooooow
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our largest impact on
@urql/exchange-graphcache
is our usage ofgraphql/utilities/buildClientSchema
which usesGraphQLSchema
and other heavy implementations, which are basically server-side implementations with a lot of invariants. Given that we know that with@urql/introspection
and other introspection methods the result can be trusted we don't even need any of the strict validation ofbuildClientSchema
and what it pulls in.Furthmore, we don't need any of the
graphql/type/definition
types, e.g.GraphQLObjectType
and helpers likeisObjectType
if we transform the client schema to a format that is just good enough for our purposes.This change increases
@urql/exchange-graphcache
's size slightly from6.74kB gzip
to6.93kB gzip
. However, the impact on what's pulled in fromgraphql
is significant and we save in-9.61kB gzip
(up to; lowest,8.53kB
). This makes a net impact of-9.42kB gzip
Set of changes
buildClientSchema
and replaceGraphQLSchema
typesbuildClientSchema
to what's necessary, but then transitioned to just using string-based schema structurestore.ts
andschemaPredicates.ts
to use new implementationNo unit tests had to be updated, which is encouraging.
The only remaining usage of
graphql
compared to@urql/core
isvalueFromASTUntyped