(core) - Add fragment deduping to gql tag #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a1bfa80 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
changed the title
kitten
force-pushed
the
feat/dedupe-fragments-gql
branch
from
0e0ea88
to
d90aeed
Compare
JoviDeCroock
approved these changes
Dec 11, 2020
kitten
force-pushed
the
feat/dedupe-fragments-gql
branch
from
d90aeed
to
fc3bde1
Compare
kitten
force-pushed
the
feat/dedupe-fragments-gql
branch
from
fc3bde1
to
a1bfa80
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change implements a missing feature of the
gqltag. While it previously warned about fragments with duplicate names, it didn't check whether these fragments were identical and deduplicated them. This change implements fragment deduplication and solidifies some of ourDocumentNode#__keyandASTNode#locadditions.Set of changes
gqldocumentASTNode.locinstringifyDocumentgqlto apply this behaviour to rawDocumentNodeinputs only