Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update subscriptions.md #1821

Merged
merged 3 commits into from Jul 28, 2021
Merged

Update subscriptions.md #1821

merged 3 commits into from Jul 28, 2021

Conversation

andyrichardson
Copy link
Contributor

Summary

Minor tweaks to the subscriptions docs.

Set of changes

  • Change precedence of subscription methods
  • Add deprecation notice to subscriptions-transport-ws
  • Trim code examples down
  • Decrease verbosity of graphql-ws instructions (maybe too much information IMHO)

@changeset-bot
Copy link

changeset-bot bot commented Jul 27, 2021 •
edited

⚠️ No Changeset found

Latest commit: 6c7a07d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

JoviDeCroock
JoviDeCroock approved these changes Jul 27, 2021
View reviewed changes
Copy link
Collaborator

@JoviDeCroock JoviDeCroock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kitten
kitten reviewed Jul 27, 2021
View reviewed changes
docs/advanced/subscriptions.md Outdated Show resolved Hide resolved
docs/advanced/subscriptions.md Show resolved Hide resolved
@andyrichardson andyrichardson merged commit 48fa13a into main Jul 28, 2021
@andyrichardson andyrichardson deleted the update-subscription-docs branch July 28, 2021 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitten kitten kitten left review comments

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andyrichardson @kitten @JoviDeCroock