(react) - leverage the new use-sync-external-store package
#2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 092abb6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
reviewed
Dec 27, 2021
kitten
reviewed
Dec 27, 2021
kitten
reviewed
Dec 27, 2021
kitten
reviewed
Dec 27, 2021
Co-authored-by: Phil Pluckthun <phil@kitten.sh>
JoviDeCroock
force-pushed
the
use-sync-ext-store
branch
from
c7f3d5d
to
8e55fe1
Compare
JoviDeCroock
changed the title
use-sync-external-store package
Merged
kitten
approved these changes
Jan 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Leverage the new
use-sync-external-storeforuseQueryto make the implementation more in line with React. Our current implementation works already with React Suspense, ... but having an implementation that coexists with React will be better for future changes.Todos:
Sandbox demo
Set of changes
synx-external-storeforuseQueryanduseSubscription