(fix) - make all components in examples have displayNames in devtools #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitten
approved these changes
Jul 3, 2019
|
Hmm, sailci seems to be stuck. Looking forward to the devtools ^^ |
|
@JoviDeCroock all the integrity checks on our yarn.lock files are deleted. Are you trying to hack us? Just kidding - but can you exclude those lock file changes from the PR and I'll get the rest merged today 👌 |
|
@andyrichardson I really don’t know why that happened, I’ll update yarn and revert the change. Sorry for the inconvenience, I’ll have time this weekend not at my pc this week. No problem if you want to do this. |
…urql into fix/examplesDisplayNames
|
@JoviDeCroock @andyrichardson going to merge this along with #348 to clean up our PR tab a little! Looks like all integrity hashes were returned and the changes otherwise look really good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exploring your devtools I noticed that there were a lot of places where the component would be labelled as
<Unknown>in the React devtools. This fixes this issue for the examples.It also cleans out some stale deps and subdeps from the
yarn.lockfiles.