Fix commutative squashing failing when lowest layer resolved earlier than others #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commutative squashing would previously only start when the lowest commutative layer (the first one) was written. This ignored the case however of when this layer has already been written. When this was the case the stopping condition was unreachable and commutative layers were never squashed. The change is to continuously squash the commutative layers with the least priorities as they're written. This change also gets rid of the temporary `squash` queue, which ends up making it a rather nice implementation.
🦋 Changeset is good to goLatest commit: db3dbca We got this. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
JoviDeCroock
approved these changes
Mar 8, 2020
We can actually get rid of the double iteration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commutative squashing would previously only start when
the lowest commutative layer (the first one) was written.
This ignored the case however of when this layer has already
been written. When this was the case the stopping condition
was unreachable and commutative layers were never squashed.
The change is to continuously squash the commutative layers
with the least priorities as they're written.
This change also gets rid of the temporary
squashqueue,which ends up making it a rather nice implementation.
Resolve #574