(graphcache) - Fix edge cases in operation ordering #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Ensure that reserveLayer can be called repeatedly - Apply optimistic updates later in the chain - Add last-chance reserveLayer to every query/subscription
🦋 Changeset is good to goLatest commit: 11ca879 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
changed the title
JoviDeCroock
approved these changes
Mar 18, 2020
kitten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #633
Summary
Previously the
cacheExchangecode had trouble with results coming in "spontaneously". It also erroneously created optimistic layers for queries and mutations at the wrong time.createLayerexacerbated the issue by not being idempotent.On a side note, sorry for commutativity causing issues for some of you! But we believe that it'll eventually strengthen our caching guarantees and make all caching operations more predictable in the face of timing changes. So we hope that after ironing out its flaws and adding more tests that it'll be a great addition!
Set of changes
optimisticUpdatelogic into the laterprepareForwardedOperationto avoid further mistakesnoopDataState(store.data, operation.key, true /* meaning optimistic */);from being called for all queries and mutations and replace it withreserveLayerreserveLayerfor results that came in without a reservation (subscriptions need this, but queries may also need it)createLayernot being idempotent