(fix) - invalidate null link #694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: c8b6a68 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
reviewed
Apr 12, 2020
kitten
reviewed
Apr 12, 2020
| @@ -18,7 +18,7 @@ export const invalidateEntity = ( | |||
|
|
|||
| for (let i = 0, l = fields.length; i < l; i++) { | |||
| const { fieldKey } = fields[i]; | |||
| if (InMemoryData.readLink(entityKey, fieldKey)) { | |||
| if (InMemoryData.readLink(entityKey, fieldKey) !== undefined) { | |||
kitten
approved these changes
Apr 12, 2020
|
Thanks for the expedition here! Is there any chance of releasing a patch with this? |
|
@olistic I’ll get to releasing this tomorrow 👍 in the meantime you should be able to test this using CodeSandbox CI which publishes temporary packages per PR |
|
Thank you @kitten, this is a great tip! 🚀 |
|
@olistic this has now been released 🌟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was an issue in invalidation when a link was null, this lead to the cache invalidating a record instead of the link since we were checking for a truthy value rather than just undefined.
Fixes: #693
Set of changes
!== undefinedso we account fornull