(graphcache) - Implement RFC for optimistic behavior enhancements #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set<string> => Record<string, true>
🦋 Changeset is good to goLatest commit: 2648544 We got this. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
kitten
force-pushed
the
feat/optimistic-mutation-enhancements
branch
from
c1c7e22
to
4c7cc93
Compare
kitten
force-pushed
the
feat/optimistic-mutation-enhancements
branch
from
a32ef53
to
3cdb60b
Compare
|
Both new strategies seem to be working. It's pretty exciting how this makes both aspects of optimistic mutations (refetching while they're active, and settling with/without optimistic updates) more intuitive. This branch only needs some new unit tests. |
kitten
force-pushed
the
feat/optimistic-mutation-enhancements
branch
from
3cdb60b
to
bc20f8a
Compare
The semaphore map isn't necessary anymore as all optimistic mutation results are flushed at the same time.
kitten
changed the title
Previously we called clearLayer when clearing an optimistic mutation result batch, which may erase existing mutation result data. This shouldn't be possible but we can account for duplicate mutation results this way and also stop exposing clearLayer.
kitten
force-pushed
the
feat/optimistic-mutation-enhancements
branch
from
2215228
to
398254f
Compare
JoviDeCroock
approved these changes
Apr 24, 2020
wgolledge
approved these changes
Apr 24, 2020
kitten
changed the title
|
Guys, as explained here I created a new CodeSandbox with an entire CRUD! We can test on it this amazing work! (I'll in a few minutes, I'm on smartphone). Thank you guys! 😄 |
|
From the first tests everything seems to work! 🥳 |
|
This has been released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements both recommendations from RFC #747.
These changes have been validated and tested so far against @frederikhors' unexpected behaviour reproductions in CodeSandboxes:
Set of changes
Set<string>totype Dependencies = Record<string, true>Dependencies)executePendingOperationsto trigger refetch for previously blockedcache-and-networkoperations