(graphcache) - Add root operation type traversal warning #859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #858
Summary
Add warning for queries that traverse an Operation Root Type (Mutation / Subscription types occuring in a query result)
It's possible for someone to explicitly use
Mutation
orSubscription
insideQuery
, which by convention is discouraged and shouldn't be done. The worst that we do in such a case is now issue a warning, but I believe it's more important to prevent this mistake than to ignore it silentily, especially since it's extremely uncommon.Set of changes
readSelection
for non-Query root types and issue warningerrors.md