Do not merge: Centralised caching via cacheExchange #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The cacheExchange now invalidates using new methods on the client. These methods update the cache but also dispatch an event for components to listen to. These new events are also reflected on the events interface definitions.
The Client will now send events to all components to indicate that they should check the cache if their known cache keys match the event payload.
kitten
force-pushed
the
feature/central-exchange-caching
branch
from
f1f5885
to
0b6d832
Compare
kitten
force-pushed
the
feature/central-exchange-caching
branch
from
99fca57
to
3b9c2ed
Compare
This was referenced Jul 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do not merge this into
nextas it's supposed to be outside of the0.3release's scopeThis moves all caching logic to exchanges. To be more precise, when the
cacheExchangenow invalidates or updates the cache it does so via a client method. This client method also dispatches events to all components that can then check the cache keys they receive against the ones that they got from sending the last query operation.Hence the components don't have to perform any cache logic themselves. They rely on receiving events from the client and that when executing a query operation the updated operation will go through the cache again, updating the component.