Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(graphcache) - Fix updates config for renamed root schema types #984

Merged
merged 6 commits into from
Sep 18, 2020

Conversation

kitten
Copy link
Member

@kitten kitten commented Sep 18, 2020

Summary

When the schema contained differently named root types, e.g. root_mutation instead of just Mutation the store.updates config would be malformed and would even at times cause runtime crashes. This is now fixed by reformatting the updates config to contain the correct keys.

Set of changes

  • Use actual root names in store.updates keys
  • Update schema predicates to use new updates
  • Simplify schema predicates calls in store.ts

@changeset-bot
Copy link

changeset-bot bot commented Sep 18, 2020

🦋 Changeset is good to go

Latest commit: 98d0521

We got this.

This PR includes changesets to release 1 package
Name Type
@urql/exchange-graphcache Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kitten kitten changed the title (graphcache) Fix updates config for renamed root schema types (graphcache) - Fix updates config for renamed root schema types Sep 18, 2020
@kitten kitten merged commit 6dbbacd into main Sep 18, 2020
@kitten kitten deleted the fix/graphcache-root-type-updates branch September 18, 2020 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants