Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Polar Charts #466

Merged
merged 42 commits into from
Jun 6, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
b4cac04
POC polar axis
boygirl Apr 19, 2017
09e7860
better label angles
boygirl Apr 19, 2017
babdf2d
merge master into experiment/polar
boygirl May 4, 2017
2604c3e
clean up
boygirl May 4, 2017
23e6814
support string ticks and segments of charts
boygirl May 4, 2017
771d974
safety commit
boygirl May 5, 2017
225585d
working polar scatter, line, area
boygirl May 5, 2017
bb64804
sync angles
boygirl May 5, 2017
198e121
adjust text anchors
boygirl May 5, 2017
bda3b05
temporary git dependendency
boygirl May 5, 2017
5239415
update demo
boygirl May 5, 2017
54a7009
remove radius prop
boygirl May 9, 2017
01f5359
remove default axis domains
boygirl May 9, 2017
b41c599
add parent props
boygirl May 10, 2017
03c582a
merge master
boygirl May 15, 2017
b261707
use new polar helpers, clean up demos
boygirl May 16, 2017
74a6efa
safety commit
boygirl May 17, 2017
4c93342
polar bars and polar bars with automatic width
boygirl May 18, 2017
b2fa866
better default bar width calculations
boygirl May 19, 2017
28ebc80
stacked demos, temporary git dependency
boygirl May 19, 2017
096bfca
clean up stack demo
boygirl May 19, 2017
30a0f9a
add demos for events, interpolation, and closed line paths
boygirl May 22, 2017
e0600a0
update demos
boygirl May 23, 2017
53e082c
merge master
boygirl May 24, 2017
691eca0
safety commit: transform on primitives experiment
boygirl May 27, 2017
e05fbea
Revert "safety commit: transform on primitives experiment"
boygirl May 27, 2017
5f6b342
polar animations
boygirl May 28, 2017
ec2c8c2
filter overlapping angular ticks
boygirl May 31, 2017
34cc4c7
polar option for victory-chart
boygirl May 31, 2017
a2f82b9
support start and end angle in victory chart
boygirl Jun 1, 2017
66c4d75
safety commit
boygirl Jun 2, 2017
ed1c5f6
use shared label helpers
boygirl Jun 3, 2017
ac192bc
merge master into experiment/polar
boygirl Jun 3, 2017
4cc0cda
clean up props
boygirl Jun 4, 2017
57d6086
working polar voronoi tooltips
boygirl Jun 4, 2017
ea159cf
clean up polar tooltips
boygirl Jun 4, 2017
5c57ead
working zoom container
boygirl Jun 4, 2017
2dbc984
lint and clean up specs
boygirl Jun 6, 2017
5d1693b
remove default domain padding on polar charts
boygirl Jun 6, 2017
5ba6cea
support polar selection containers
boygirl Jun 6, 2017
03324f8
remove unnecessary lint exceptions, update changelog
boygirl Jun 6, 2017
a9683c1
update victory-core
boygirl Jun 6, 2017
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 40 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,45 @@
# VictoryChart Changelog

## 21.0.0 (2017-06-06)

[466](https://github.com/FormidableLabs/victory-chart/pull/466) Polar Charts
[475](https://github.com/FormidableLabs/victory-chart/pull/475) Brush and Zoom fixes
[476](https://github.com/FormidableLabs/victory-chart/pull/476) Zoom Improvements

*Breaking Changes*
- Changes how default widths are calculated for `VictoryBar` and groups of bars
- Removes default bar widths from themes

*Overview*
- Supports polar charts by adding the `polar` prop to charts.
- Polar charts are supported for `VictoryArea`, `VictoryChart`, `VictoryGroup`, `VictoryLine`, `VictoryScatter` `VictoryStack` and `VictoryVoronoi`
- Polar charts are supported for `VictoryBar`, but horizontal (radial) bars are not yet supported
- Polar charts work with `VictoryVoronoiContainer`
- Polar charts work with `VictorySelectionContainer`, but the dimension prop is not supported for polar selections
- Polar charts work with `VictoryZoomContainer`, but zooming is limited to centered radial zooming. Panning has no effect.
- Polar-specific default animations for `VictoryLine` and `VictoryArea`
- **horizontal polar charts are not yet supported**
- **`VictoryCandlestick` and `VictoryErrorBar` do not yet work with polar charts
- **`VictoryCursorContainer` does not yet work with polar charts
- **`VictoryBrushContainer` does not work with polar charts
- **`VictoryZoomContainer` has limitations for polar charts

*Planned additional work*
- Support for radial bars
- Support for spider charts (i.e. linear grid lines rather than arcs on polar charts)
- Support separate theming for polar charts (at least axes)
- Support for a polar version of `VictoryCursorContainer`
- Minimal support for polar versions of `VictoryCandleStick` and `VictoryErrorBar` (Elements will be correctly positioned and angled, but path elements will not be altered to reflect curvature, _i.e._ candles will still be `rects` rather than arc paths)
- Investigate hollow polar charts

*Details*
- Adds `VictoryPolarAxis` with new props: `axisAngle` `startAngle`, `endAngle`, and `labelPlacement`
- Adds `polar`, `startAngle`, `endAngle`, and `defaultPolarAxes` props for `VictoryChart`
- Adds `polar`, `origin`, and `range` props to all chart types.
- Adds `defaultPolarTransitions` static methods to `VictoryLine` and `VictoryArea`
- Uses `LabelHelpers` to simplify all `helper-methods`


## 20.0.0 (2017-05-24)

*Breaking Changes*
Expand Down
5 changes: 5 additions & 0 deletions demo/app.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ import CreateContainerDemo from "./components/create-container-demo";
import BrushContainerDemo from "./components/victory-brush-container-demo";
import AnimationDemo from "./components/animation-demo";
import SelectionDemo from "./components/selection-demo";
import PolarDemo from "./components/victory-polar-chart-demo";
import DebugDemo from "./components/debug-demo";

class Home extends React.Component {
Expand Down Expand Up @@ -70,6 +71,7 @@ class App extends React.Component {
case "/animation": Child = AnimationDemo; break;
case "/selection-container": Child = SelectionDemo; break;
case "/create-container": Child = CreateContainerDemo; break;
case "/polar": Child = PolarDemo; break;
case "/debug": Child = DebugDemo; break;
default: Child = Home;
}
Expand Down Expand Up @@ -101,6 +103,7 @@ class App extends React.Component {
<li><a href="#/animation">Animation Demo</a></li>
<li><a href="#/selection-container">Victory Selection Container Demo</a></li>
<li><a href="#/create-container">createContainer Demo</a></li>
<li><a href="#/polar">Polar Demo</a></li>
</ul>
<Child/>
</div>
Expand All @@ -109,3 +112,5 @@ class App extends React.Component {
}

ReactDOM.render(<App/>, document.getElementById("content"));


1 change: 0 additions & 1 deletion demo/components/group-demo.js
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,6 @@ class App extends React.Component {
/>
</VictoryGroup>
</VictoryChart>

</div>
</div>
);
Expand Down
10 changes: 7 additions & 3 deletions demo/components/victory-bar-demo.js
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ export default class App extends React.Component {
theme={VictoryTheme.material}
>
<VictoryGroup
offset={15}
offset={12}
animate={{ duration: 1000 }}
colorScale={"warm"}
>
Expand All @@ -283,15 +283,19 @@ export default class App extends React.Component {
})}
</VictoryGroup>

<VictoryGroup horizontal style={{ parent: parentStyle }} offset={10}
<VictoryGroup horizontal style={{ parent: parentStyle }} offset={15}
colorScale={"cool"} animate={{ duration: 2000 }} labels={["a", "b", "c"]}
>
{this.getBarData().map((data, index) => {
return <VictoryBar key={index} data={data}/>;
})}
</VictoryGroup>

<VictoryGroup style={{ parent: parentStyle }} offset={15} animate={{ duration: 2000 }}>
<VictoryGroup
style={{ parent: parentStyle, data: { width: 20 } }}
offset={25}
animate={{ duration: 2000 }}
>
<VictoryStack colorScale={"red"}>
{this.getBarData().map((data, index) => {
return <VictoryBar key={index} data={data}/>;
Expand Down
6 changes: 3 additions & 3 deletions demo/components/victory-chart-demo.js
Original file line number Diff line number Diff line change
Expand Up @@ -208,7 +208,7 @@ class App extends React.Component {
<VictoryChart style={chartStyle}>
<VictoryBar
groupComponent={<VictoryClipContainer/>}
style={{ data: { fill: "tomato", width: 20 } }}
style={{ data: { fill: "tomato" } }}
data={[
{ x: 1, y: 1 },
{ x: 2, y: 2 },
Expand Down Expand Up @@ -544,7 +544,7 @@ class App extends React.Component {
}]}
>
<VictoryBar name="bar"
style={{ data: { width: 15, fill: "green" } }}
style={{ data: { fill: "green" } }}
data={[
{ x: 1, y: 1 },
{ x: 2, y: 2 },
Expand All @@ -567,7 +567,7 @@ class App extends React.Component {
/>
</VictoryChart>
<VictoryChart style={chartStyle} domainPadding={{ x: 50 }} animate={{ duration: 2000 }}>
<VictoryGroup offset={15}>
<VictoryGroup offset={20} style={{ data: { width: 15 } }}>
<VictoryStack colorScale={"red"}>
{this.getBarData().map((data, index) => {
return <VictoryBar key={index} data={data}/>;
Expand Down
Loading