This repository has been archived by the owner on Feb 19, 2022. It is now read-only.
replace lodash omit #577
Merged
replace lodash omit #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryan-roemer
approved these changes
Apr 3, 2018
|
@chrisbolin I'm definitely in favor of removing lodash omit even if it only gives us moderate performance improvement. |
|
I think most of the uses of omit can actually be removed anyway, since we added a whitelist for svg styles: https://github.com/FormidableLabs/victory-core/blob/master/src/victory-util/style.js#L24 |
|
now that we've done FormidableLabs/victory-core#347, i can revisit this PR and remove the duplicate |
chrisbolin
force-pushed
the
remove-lodash-omit
branch
from
662dba8
to
0eed861
Compare
…primitives with sanitizeSvgStyle
boygirl
reviewed
Apr 4, 2018
| import { VictoryContainer, VictoryTooltip, Helpers, TextSize } from "victory-core"; | ||
| import { omit } from "victory-core/es/victory-util/helpers"; |
There was a problem hiding this comment.
It bugs me that we have just this one use of omit left outside of victory-core. What do you think about refactoring it to use a different method all together?
chrisbolin
force-pushed
the
remove-lodash-omit
branch
from
0eed861
to
78260d2
Compare
|
@boygirl how about this approach? |
|
github doesn't have the emoji I want to express my approval. :the_horns: |
chrisbolin
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
lodash.omitinstance withvictory-core'somitfor performance: see Replace lodash.omit for performance victory#956 for moreesandlibmodule paths correctlyPreliminary Results
@tptee reported that
_.omitingetDataStyleswas a bottleneck for an application he was working on. Here are the testing results on a modified version ofvictory-brush-container-demo.jswith 800 points,VictoryScatter(rather thanVictoryLine, as scatter callsgetDataStyleson every point),VictoryBrushContainer, andVictoryZoomContainer:getDataStylesself-time improved by 4.7x (i.e. it now only takes about a fifth of the time to execute)Again, this was just a quick test I threw together; not the application that had actually ID'd
getDataStylesandomitas bottlenecks.Open Questions
builder-victory-componentarchetype?omit), removes a function that many other projects have had trouble with, establishes named exports fromvictory-coreintovictory-chart.Notes
Because
victory-core's omit change has been merged by not released (intentionally, just in case work invictory-chartnecessitated more changes), all my work was done onlank; tests using the actualvictory-corewill fail. If we approve these changes, I'll make avictory-corerelease, update the dependency here, and then ensure everything passes on this PR.