Skip to content
This repository has been archived by the owner on Feb 19, 2022. It is now read-only.

Improvement/legend #294

Merged
merged 14 commits into from
Sep 8, 2017
Merged

Improvement/legend #294

merged 14 commits into from
Sep 8, 2017

Conversation

boygirl
Copy link
Contributor

@boygirl boygirl commented Sep 8, 2017

This PR includes several improvements for VictoryLegend:

This may be a breaking change for VictoryLegend

  • Adds a border component that can be styled or replaced with a custom component
    new props: borderComponent={<Border/>} and borderPadding
    style / event namespace: "border"

  • Adds new primitive component Border
    renders a rect element
    props: common props + width, height, x and y

  • Adds a title component with supporting props for positioning and center titles
    new props: title, titleComponent={<VictoryLabel/>}, titleOrientation, centerTitle
    style / event namespace: "title"

screen shot 2017-09-09 at 2 02 59 pm

fixes FormidableLabs/victory#714
fixes FormidableLabs/victory#729
fixes FormidableLabs/victory#736

@boygirl boygirl merged commit a934a12 into master Sep 8, 2017
@boygirl boygirl deleted the improvement/legend branch September 8, 2017 22:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
1 participant