feat: pie chart #191
Merged
feat: pie chart #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 73017da The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Closed
carbonrobot
reviewed
Feb 28, 2024
keithluchtel
approved these changes
Mar 20, 2024
| @@ -0,0 +1,6 @@ | |||
| --- | |||
| "victory-native": minor | |||
| "example": patch | |||
There was a problem hiding this comment.
do we want the example app in here?
There was a problem hiding this comment.
Seemed like it automatically got included when I generated the changeset.
carbonrobot
approved these changes
Mar 20, 2024
This is a v1 pie chart implementation that renders pie charts, without labels and without gestures. It sort of only has one option beyond the pie chart, which is to render an inset inside the chart, which is like a border of each slice. No docs yet either, beside the example page, which only renders in dev mode currently.
- adds pie chart legend support - adds contexts to consume slices/set legend position, and probably more later. - readjusts exports/implementation - adds label, but not exported yet (wip)
fixes some clipping that was happening since the canvas is a bit tight
This adds an `innerRadius` prop that allows the Pie chart to function as a donut chart.
adds pie and donut chart example screen that covers a few edge cases/examples to ensure things are working
- removes need to import provider for rendering slices - removes need to pass data prop to legend - adds data to pie chart context so legend can consume it - make render props optional and render defaults unless otherwise passed in - updates examples
type becomes:
```
type PieSliceAngularInsetData = {
angularStrokeWidth: number;
angularStrokeColor: Color;
};
```
follows same pattern as the `Pie.ChartSlice` component where we just wrap the children with the slice provider.
- adds parent Polar component as Pie chart coordinate system container. - updates docs - removes legends/legend items for now
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a v1 pie chart implementation that renders pie charts, without labels and without gestures.
It sort of only has one option beyond the pie chart, which is to render an inset inside the chart, which is like a border of each slice.
No docs yet either, beside the example page, which only renders in dev mode currently.
Fixes # (issue)
#141
Checklist: (Feel free to delete this section upon completion)
yarn run check:codeand all checks pass