Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend axisOptions lineWidth & lineColor API #209

Merged
merged 11 commits into from
Mar 19, 2024
Merged

Conversation

masiddee
Copy link
Contributor

@masiddee masiddee commented Mar 11, 2024

Description

Fixes #179

This is a small improvement to allow custom configuration of the color and line width of the x/y axis independently. For example, with this change the user can choose to only display either the x or y axis:

Screen Shot 2024-03-13 at 2 32 32 PM

Type of Change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Mar 11, 2024

🦋 Changeset detected

Latest commit: 75dfa21

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 14, 2024 4:51pm

@masiddee masiddee marked this pull request as ready for review March 13, 2024 18:30
@masiddee masiddee changed the title WIP: Extend axisOptions lineWidth & lineColor API Extend axisOptions lineWidth & lineColor API Mar 13, 2024
lib/src/types.ts Outdated Show resolved Hide resolved
@zibs
Copy link
Contributor

zibs commented Mar 15, 2024

Sweet! This looks good to me!

@masiddee masiddee merged commit a303524 into main Mar 19, 2024
3 checks passed
@masiddee masiddee deleted the feat/custom-grid-lines branch March 19, 2024 18:14
@github-actions github-actions bot mentioned this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Independent customization of X and Y axes of the grid
4 participants