Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always hide tooltip onEnd of cartesian pangesture #230

Merged
merged 2 commits into from
Apr 10, 2024

Conversation

peterjskaltsis
Copy link
Contributor

@peterjskaltsis peterjskaltsis commented Apr 4, 2024

Description

Ensures tooltip disappears once the user stops panning the chart. This should resolve #213 @zibs.
By wiping the active values array on PanGesture .onEnd the tooltip is forced to hide when your finger stops gesturing.

Fixes #213

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Tested locally as a package change in node_modules in my app.

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Ensures tooltip disappears once the user stops panning the chart
Copy link

changeset-bot bot commented Apr 4, 2024

🦋 Changeset detected

Latest commit: 7d6a05e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Apr 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 7:25pm

@peterjskaltsis peterjskaltsis changed the title fix: add onEnd callback for cartesian pangesture fix: always hide tooltip onEnd of cartesian pangesture Apr 4, 2024
@zibs zibs self-assigned this Apr 8, 2024
@zibs
Copy link
Contributor

zibs commented Apr 9, 2024

@peterjskaltsis Can you add a changeset? See above ^! Nevermind, I was able to do it!

Copy link
Contributor

@zibs zibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zibs zibs merged commit 0bbf3f4 into FormidableLabs:main Apr 10, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip remains displayed after changing time range in the chart
2 participants