add default upper and lower x/y bounds if single data point

[masiddee]

Description

Fixes issue #207

The problem here is we do not enforce at least 2 distinct data points, so whenever a user adds a data array with a single data point (or an array with multiple identical data points), we'd throw a duplicate key warning and the chart UI would break.

This fix simply checks the following: if the min and max bounds are the same, then manually append an upper and lower bound.

Type of Change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

• I have included a changeset if this change will require a version change to one of the packages.
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have run yarn run check:code and all checks pass
• I have created a changeset for new features, patches, or major changes
• I have added tests that prove my fix is effective or that my feature works
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[changeset-bot]

🦋 Changeset detected

Latest commit: 0f0bd87

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
victory-native	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
victory-native-xl-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Apr 17, 2024 10:41pm

[zibs]

LGTM! Aside from the small comments

[zibs]

But I'm not 100% this is exactly what we want to do, have you tried using a Set to remove the duplicate ticks before rendering? That may be another option?

[masiddee]

But I'm not 100% this is exactly what we want to do, have you tried using a Set to remove the duplicate ticks before rendering? That may be another option?

@zibs yep. I played around with using a Set, and it successfully resolves the duplicate keys warning, but it does not resolve the chart rendering weirdness. I also briefly played around with updating the types to enforce at least 2 data points, but felt that was an unnecessary restriction, as there could be a number of valid reasons a user would want to display a single data point graph.

Essentially, I figured my options were:

• De-dupe the ticks array
• Enforce 2 data point min in TS/Add a ListEmptyProp prop to display, as suggested on the issue
• Massage the upper/lower bounds if single data point provided (✅ preferable, as it was least intrusive option, and neatly resolved the issues)

[zibs]

Dang! Yep okay, maybe this is the best option then! @keithluchtel Feel free to take a look if you want!