-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/custom bar width #238
Conversation
🦋 Changeset detectedLatest commit: b8ebfb7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. 🚀
One question: do we want to update the example app in this PR?
ae29cbf
to
9e8fc72
Compare
Description
Adds
barWidth
prop toBar
andBarGroup
. This prop lets you adjust the specific bar width in pointsAdds
barCount
prop toBar
andBarGroup
. This prop lets you adjust the bar width based on the amount of data points present. So if you had only one data point, but wanted the width to be as if you had 4 data points, you would addbarCount={4}
as mentioned in: #196 (comment)Gotta update docs.Fixes #196
Without the prop and single data point:
![Simulator Screenshot - iPhone 15 Pro - 2024-04-18 at 12 38 35](https://private-user-images.githubusercontent.com/1131641/323740788-66bd2fc9-1e76-45db-861f-5934373e7f4c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgzMTUwNzMsIm5iZiI6MTcxODMxNDc3MywicGF0aCI6Ii8xMTMxNjQxLzMyMzc0MDc4OC02NmJkMmZjOS0xZTc2LTQ1ZGItODYxZi01OTM0MzczZTdmNGMucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDYxMyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA2MTNUMjEzOTMzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MmNhMTg2YzNjOWIxZTVjYzgzZWU2NmU0ZmExYmY5YmU3MmIxNzYzYTBkZDE3ODY0ZWQ1NzZjNmRmYzNiMzkzOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.z2tsbQj5PTTfUKlmQxpWTCop6AesNOqf6-notTWTlBo)
With!
Type of Change
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)
yarn run check:code
and all checks pass