-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upgrade expo, RN, and Skia (and deps) #259
Conversation
🦋 Changeset detectedLatest commit: 80e45df The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. We should make sure we merge and release any minor issues we have outstanding before we merge this one.
I'm noticing a fairly easy to reproduce crash with Skia here on the Stock chart demo -- gonna see if I can reproduce on main before proceeding here |
Okay, the latest commits seems to have fixed the crash I was seeing! |
removes reanimated plugin removes android/ios bumps to latest version packages
I don't think this was ever supported internally by the code... And the slightly different signatures of each call makes it so we have to add type guards so that TS can properly infer the args
Description
Bumps Expo, RN and RNSkia in preparation for Expo's next release. This will let us bump our minimum supported Skia version so that we can use a few new APIs and features now that RNSkia has hit 1.0.
This also gitignores the
/android
and /ios
folders we were using previously. Now, if one wants to prebuild or add custom functionality, they can do that while testing more easily. This should keep things a bit simpler.Will also need FormidableLabs/react-native-dark#8 to land tooType of Change
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)
yarn run check:code
and all checks pass