feat: add support for negative bar values #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 9d8d244 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
carbonrobot
reviewed
May 9, 2024
| @@ -17,6 +18,8 @@ export const useBarGroupPaths = ( | |||
| ) => { | |||
| const numGroups = points[0]?.length || 0; | |||
|
|
|||
| const { yScale } = useCartesianChartContext(); | |||
zibs
force-pushed
the
feat/negative-number-bar-charts
branch
from
a7c9853
to
75bf41c
Compare
removes reanimated plugin removes android/ios bumps to latest version packages
removes reanimated plugin removes android/ios bumps to latest version packages
- adds negative chart example to repo - support rounded corners by using Skia's new `NonUniformRRect`. Removes test now that it's not a custom function. - Adds context provider to Cartesian chart that allows us to access the scale functions inside the charts
zibs
force-pushed
the
feat/negative-number-bar-charts
branch
from
75bf41c
to
9d8d244
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NonUniformRRect. Removes test now that it's not a custom function.Fixes #178
Screen.Recording.2024-05-09.at.2.16.04.PM.mov
Type of Change
How Has This Been Tested?
Checklist: (Feel free to delete this section upon completion)
yarn run check:codeand all checks pass