Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #264 empty pie charts #266

Merged
merged 3 commits into from
May 14, 2024
Merged

fix: #264 empty pie charts #266

merged 3 commits into from
May 14, 2024

Conversation

zibs
Copy link
Contributor

@zibs zibs commented May 10, 2024

Description

Fixes #264

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

zibs added 3 commits May 10, 2024 14:52
It's possible to pass multiple elements that may have a value of zero, and still an element with a valid value. This lets the pie chart render correctly in that case.

Before we were just checking if there was only a single data point, which missed this case.
different case here, I just missed adding these to the demo example
Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 10:04pm

Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: 0f10102

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zibs zibs merged commit 54ce6a6 into main May 14, 2024
3 checks passed
@zibs zibs deleted the fix/264-empty-pie-charts branch May 14, 2024 15:21
@github-actions github-actions bot mentioned this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pie chart doesn't render when only one data object is nonzero
2 participants