Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: useAnimatedPath will no longer jump when interupted #287

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

ljukas
Copy link
Contributor

@ljukas ljukas commented Jun 3, 2024

Description

When using useAnimatedPath and you change the path during the animation from state A -> B, the animation will jump to state B and then start the new animation. This leads to jumpy animations. This change changes this so that if you interrupt the animation between state A -> B, the new animation will begin from the current state which can be anywhere between state A and B before animation to state C

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Any path using useAnimatedPath and interrupt it by changing the path during the animation

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass // Things that fail are independent of my changes
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Jun 3, 2024

🦋 Changeset detected

Latest commit: 0322b1e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 4, 2024 7:39pm

@ljukas ljukas changed the title fix: useAnimatedPath will not jump when interuppted fix: useAnimatedPath will no longer jump when interupted Jun 3, 2024
Copy link
Contributor

@zibs zibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @ljukas this looks and works good to me!

@zibs zibs merged commit 2b22f91 into FormidableLabs:main Jun 4, 2024
2 checks passed
@github-actions github-actions bot mentioned this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants