Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix negative bar group charts #295

Merged
merged 3 commits into from
Jun 14, 2024
Merged

fix negative bar group charts #295

merged 3 commits into from
Jun 14, 2024

Conversation

zibs
Copy link
Contributor

@zibs zibs commented Jun 5, 2024

Description

We need to check if there are negative values in any of the pointsets, and then draw from there if so.

Fixes #292

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

zibs added 2 commits June 5, 2024 12:26
We need to check if there are negative values in any of the pointsets, and then draw from there if so.
Copy link

vercel bot commented Jun 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 7:32pm

Copy link

changeset-bot bot commented Jun 5, 2024

🦋 Changeset detected

Latest commit: 6ef3341

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zibs zibs merged commit cbf076e into main Jun 14, 2024
3 checks passed
@zibs zibs deleted the fix/negative-bar-group-charts branch June 14, 2024 20:23
@github-actions github-actions bot mentioned this pull request Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Negative values on cartesian chart do not work as expected
2 participants