Skip to content

Commit

Permalink
Revert "Uncomment pow-sqrt duck type"
Browse files Browse the repository at this point in the history
This reverts commit ec078d5.
  • Loading branch information
Becca Bailey committed May 10, 2022
1 parent 4e486ea commit 733aff1
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions packages/victory-core/src/victory-util/scale.js
Original file line number Diff line number Diff line change
Expand Up @@ -114,14 +114,13 @@ export function getScaleType(props, axis) {
// **Note**: Brittle because reliant on d3 internals.
const DUCK_TYPES = [
{ name: "quantile", method: "quantiles" },
{ name: "log", method: "base" },
// This is not documented, but is required for the log scale Storybook examples
{ name: "pow-sqrt", method: "exponent" }
{ name: "log", method: "base" }
// TODO(2214): Re-evaluate (1) duck typing approach, and (2) if duck typing,
// do we need a different approach? (Multiple keys? Stringifying functions?)
// https://github.com/FormidableLabs/victory/issues/2214
// Below are matches that don't seem to otherwise occur in Victory code base.
// { name: "ordinal", method: "unknown" },
// { name: "pow-sqrt", method: "exponent" },
// { name: "quantize-threshold", method: "invertExtent" }
];

Expand Down

0 comments on commit 733aff1

Please sign in to comment.