Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VictoryBoxPlot: Make labelOrientation accept array of positions #1234

Closed
2 tasks done
mAAdhaTTah opened this issue Jan 18, 2019 · 2 comments
Closed
2 tasks done

VictoryBoxPlot: Make labelOrientation accept array of positions #1234

mAAdhaTTah opened this issue Jan 18, 2019 · 2 comments

Comments

@mAAdhaTTah
Copy link
Contributor

Feature Request

Checklist

  • I've read through the Docs and Guides to make sure this functionality doesn't already exist

  • I've searched open issues to make sure I'm not opening a duplicate issue

Description

I'm working with the BoxPlot and in our data sets, we're often seeing the labels overlap with one another. We'd like to solve this by alternating the position of the labels, so min, median, & max all sit above the box plot and Q1 & Q3 sit below.

Given the API used elsewhere, modifying labelOrientation to take an array of values might make sense to solve this issue. I'd be willing to contribute a PR if this is something that would be accepted.

@boygirl
Copy link
Contributor

boygirl commented Feb 2, 2019

Rather than an array, I think this prop would work well as an object with values for { q1, q1, min, max, median }.

@mAAdhaTTah
Copy link
Contributor Author

@boygirl Sounds good! Working on it now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants