Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept object for label orientation #1247

Conversation

mAAdhaTTah
Copy link
Contributor

Fixes #1234.

This is what it looks like in the demo:

screen shot 2019-02-04 at 11 55 23 am

The labels with "bottom" also overlap with the chart when labelOrientation is just "bottom", so this isn't directly related to my changes. Dunno if that's something you want me to fix here or if you have an issue for that.

I had to extract getLabelOrientation cuz ESLint was complaining about function complexity. Also wondering the props types are in "style". Dunno if we should provide a default fallback if people leave out a specific label's orientation? This seemed like the least-invasive implementation though.

@mAAdhaTTah
Copy link
Contributor Author

Couple things about the test failures:

  1. When I ran prettier over the files, I got a lot of additonal changes, that I thought might be better for a separate PR, so I didn't include all of those.
  2. It looks like it's also failing on Chromatic, which I don't have a key for. Not sure how you're handling this for outside contributors.

@boygirl boygirl mentioned this pull request Feb 23, 2019
@boygirl
Copy link
Contributor

boygirl commented Feb 23, 2019

@mAAdhaTTah sorry for the delay! These changes look good. I've opened a new PR with your changes in order to get chromatic to run. #1256

@boygirl boygirl closed this Feb 23, 2019
@mAAdhaTTah mAAdhaTTah deleted the accept-object-label-orientation branch February 24, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VictoryBoxPlot: Make labelOrientation accept array of positions
2 participants