Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task/audit victory candlestick typescript props #1512

Merged
merged 12 commits into from
Apr 21, 2020
Merged

Task/audit victory candlestick typescript props #1512

merged 12 commits into from
Apr 21, 2020

Conversation

wsparsons
Copy link
Member

@wsparsons wsparsons commented Apr 16, 2020 •
edited

What it does?

  • Audits the prop typescript definitions for VictoryCandlestick
  • Adds a VictoryCandlestickDemo
  • Adds and defines the props for VictoryCandlestickProps
  • Adds and updates props to VictoryCommonProps and VictoryDatableProps
  • Removes duplicated samples, sortOrder, and range props from VictoryCommonProps and VictoryScatterProps since they are defined in the common interfaces.
  • Removes labels from the demo

@wsparsons wsparsons mentioned this pull request Apr 20, 2020
Closed
24 tasks
@boygirl
Copy link
Contributor

boygirl commented Apr 20, 2020

@wsparsons I'm seeing some errors when running nps check.dev

@wsparsons
Copy link
Member Author

wsparsons commented Apr 20, 2020 •
edited

@boygirl I accidentally imported the wrong file. let me push up some of the current fixes. I am still working through the rest of the errors

@wsparsons wsparsons force-pushed the task/audit-victory-candlestick-typescript-props branch from 9f16bc9 to cb9b9f9 Compare April 20, 2020 22:44
@wsparsons wsparsons marked this pull request as ready for review April 21, 2020 01:22
@wsparsons wsparsons force-pushed the task/audit-victory-candlestick-typescript-props branch from 7bf2884 to 3ca09ca Compare April 21, 2020 16:32
@boygirl
Copy link
Contributor

boygirl commented Apr 21, 2020

@wsparsons This is looking great! Just a couple small comments to resolve, then good to go.

@wsparsons wsparsons force-pushed the task/audit-victory-candlestick-typescript-props branch from 3ca09ca to d4f7172 Compare April 21, 2020 22:37
boygirl
boygirl approved these changes Apr 21, 2020
View reviewed changes
Copy link
Contributor

@boygirl boygirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@wsparsons wsparsons merged commit f3e3e7d into master Apr 21, 2020
@wsparsons wsparsons deleted the task/audit-victory-candlestick-typescript-props branch April 21, 2020 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boygirl boygirl boygirl approved these changes

@maddles maddles Awaiting requested review from maddles

@kale-stew kale-stew Awaiting requested review from kale-stew

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@wsparsons @boygirl @kale-stew