Add types and demo: VictoryBrushContainer #1522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 tasks
…d to be provided initially for the x and y
wsparsons
force-pushed
the
task/audit-victory-brush-container-typescript-props
branch
from
5544e5c
to
06f6e94
Compare
boygirl
reviewed
Apr 23, 2020
| brushStyle?: React.CSSProperties; | ||
| clipContainerComponent?: React.ReactElement; | ||
| defaultBrushArea?: "all" | "none" | "disable"; |
There was a problem hiding this comment.
defaultBrushArea should include the option "move"
boygirl
reviewed
Apr 23, 2020
| brushStyle?: React.CSSProperties; | ||
| clipContainerComponent?: React.ReactElement; | ||
| defaultBrushArea?: "all" | "none" | "disable"; | ||
| disable?: boolean; | ||
| downsample?: number | boolean; | ||
| minimumZoom?: CursorData; |
There was a problem hiding this comment.
CursorData is a really confusingly named variable. I know you didn't name it, but do you mind changing it?
maddles
approved these changes
Apr 23, 2020
|
@boygirl We decided to merge this and keep |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VictoryBrushContainerDemoRangeTupleinstead ofDomainPropTypesince it is possible to have the prop to not be provided initially, thereforeDomainPropTypeis the wrong type definition due to it requiring eitherxoryVictoryBrushContainerPropsinterface