Add types: VictoryErrorBar #1528
Conversation
kale-stew
force-pushed
the
types/victory-errorbar
branch
from
3b36efb
to
76ba339
Compare
| errorY?: number | number[]; | ||
| }; | ||
|
|
||
| export interface VictoryErrorBarProps extends VictoryCommonProps { |
There was a problem hiding this comment.
I think VictoryErrorBarProps might need to extend the following:
- extends
VictoryLabelablePropsto account forlabelComponenthttps://formidable.com/open-source/victory/docs/victory-error-bar#labelcomponent - extends
VictoryMultiLabelablePropsto account forlabelshttps://formidable.com/open-source/victory/docs/victory-error-bar#labels - extends
VictoryDatablePropsto account forcategories,dataComponent,domain,domainPadding,samples,sortKey,sortOrder
Also adds the following missing props
eventKey?: StringOrNumberOrCallback | string[]https://formidable.com/open-source/victory/docs/victory-error-bar#eventkeyorigin?: OriginTypehttps://formidable.com/open-source/victory/docs/victory-error-bar#origin can use thisOriginType
There was a problem hiding this comment.
Thank you for catching those!
| data?: dataType | dataType[]; | ||
| errorX?: number | number[]; | ||
| errorY?: number | number[]; | ||
| events?: EventPropTypeInterface<"data" | "labels" | "parent", StringOrNumberOrCallback>[]; |
There was a problem hiding this comment.
the second argument for EventPropTypeInterface might need to add StringOrNumberOrCallback | string[] so
EventPropTypeInterface<"data" | "labels" | "parent", StringOrNumberOrCallback | string[]>[];
since eventKey type is the following string || integer || array[string] || function https://formidable.com/open-source/victory/docs/victory-error-bar#eventkey
…bleProps to VictoryError types
| VictoryLabelableProps, | ||
| VictoryMultiLabelableProps { | ||
| borderWidth?: number; | ||
| errorX?: number | number[]; |
There was a problem hiding this comment.
errorX and errorY are data accessor props like x and y on other components. They should use the same type as those, which includes functions, integers, strings, and arrays of strings.
There was a problem hiding this comment.
Ah! Sorry, question: is an array of ints allowed?
Still need to resolve various issues with the styles in the demo